Use await using in ASP.NET Core tutorial doc
#1580
Merged
+32
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesper Noordsij <[email protected]>
|
Further examples have been updated; this should be ready to review now. |
bgrainger
approved these changes
Aug 30, 2025
There was a problem hiding this comment.
The await using MySqlCommand is a bit overkill, as DisposeAsync is just a synchronous method that sets m_isDisposed = true. However, the compiler should handle a completed ValueTask efficiently, and it means client code doesn't have to be dependent on those internal details (which might change).
bgrainger
added a commit
that referenced
this pull request
Aug 30, 2025
This is a follow-up to #1580 that updates the source of the Markdown docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When browsing through the docs I encountered an example, which can probably enhanced by using
await usinggiven that all respective classes from this package implement theAsyncDisposablemethod.After further inspection, there seemed to be more examples where this would be preferable. I've attempted to update all examples where async context is clear and this thus should be preferable.